Add ParticleCount to emissions, updates to InheritsVel #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spawn per emission, and made Emissions with InheritsVel inherit velocity and angular velocity from the spin of its root parent.
…o they can have any float value
- Added InheritsVelWhenDetached and InheritsAngularVelWhenDetached to Attachables - Exposed these to Lua
Contributor
|
Do we want to merge this now or will the issues with Gibs not being modifiable from Lua being sorted first? I'm not too fussed given how awkward it is here, but I heard some chat between yourself and @Bit-Crust there so I'm unsure if you're planning on adjusting that |
Contributor
We decided it ought to be a separate branch |
Causeless
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParticleCountto Emissions which determines how many particles an emission fires out at once, defaults to 1 and has no effect on burst.InheritsAngularVelto both Gibs and Emissions, so as to allow things to inherit velocity without inheriting spin.InheritsVelWhenDetachedandInheritsAngularVelWhenDetachedto Attachables, functioning the same as the obvious parallels on Gibs and Emissions, but named for greater clarity.InheritsVelon Emissions to account for the AngularVel of the parentInheritsVeland its ilk, allowing modders to get a little sillyOF NOTE: Changing properties of gibs and emissions in Lua doesn't work as of this writing.