Skip to content

Conversation

@HeliumAnt
Copy link
Contributor

Adds pretty printed backtrace and signal handler for non windows systems using bombela/backward-cpp
(This could also do stacktrace on windows)

@HeliumAnt HeliumAnt requested a review from Causeless December 20, 2024 11:27
Copy link
Contributor

@Causeless Causeless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can we do this for Windows too? I'd rather avoid having two stack trace libs

@HeliumAnt
Copy link
Contributor Author

HeliumAnt commented Jan 12, 2025

Should pretty print backtrace on win as well now. (Pls test)

@Causeless Causeless added this pull request to the merge queue Feb 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 19, 2025
@Causeless Causeless added this pull request to the merge queue Feb 26, 2025
Merged via the queue into development with commit 9793a7d Feb 26, 2025
4 checks passed
@Causeless Causeless deleted the nonwin-backtrace branch February 26, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants