Open
Conversation
A reports directory has been added for reports generated from the code base. The dependency report has been added, and analysis of it shows heavy Efferent Coupling to model classes. One potential notion is to run mutation testing on the model class tests to ensure stability here. The report is also now available for further analysis.
Refactoring of several methods has lowered the average cyclomatic complexity to a 5.99. Further refactoring of several methods is needed to lower their cyclomatic complexity below the maintainability threshold (set at 6.0). Due to time constraints on the project, this task will be put off until a later time. Resolves: #1
The class has undergone refactoring to lower the cyclomatic complexity below 6. Larger methods have been broken into several private methods to promote readability and maintainability. Resolves: #2
Made a new method to do the if statement. reduced to 5.
Complexity reduced to 3.5
Added the report.txt file as well as a screenshot of the package violations
The subprocesses of the buildDetail method were extracted to private methods. Resolves: #3
A subprocess of the constructor was extracted to a private method. Resolves: #9
Reduced complexity from 8.50 to 6.50
Lowered from 7 to 5.50
Reduced complexity from 13 to 5.66
Reduced to 4.00
Reduced Complexity to 5.33
Reduced complexity to a crisp 4.33
Excellent Resolution.
Reduced to 5.5
Resolves: #7
Should place it at 5.86
Resolves: #5
Resolves: #4
Got it below 6
Reduced complexity from 8.50 to 5.88
Reduced complexity from 6.50 to 4.66
Reduced complexity from 6.00 to 4.75
Reduced from 6.47 to 5.99
Reduced complexity from 12.06 to 5.88
Reduced complexity from 7.12 to 5.90
got it down to 5.88
Crisp 4.57
I can't believe this works
Crisp 5.85
Tried reverting a commit
…ng from switch statement
If you have the starting name Midas you will begin the game with 500 gold.
Assigned this commit to the issue
…rom after, to illustrate the the differences in cyclomatic complexity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.