Removes disabled namespaces from approvals listing #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automatic listing generated by the
[APPROVALS]tag takes into account the namespaces in which the publish plugin is enabled (apr_namespaces) but it does not take into account the namespaces in which it is disabled (no_apr_namespaces).As a result, the listing will generally include all pages from namespaces where the plugin is disabled, as those pages can never be approved.
In the example below the publish plugin is disabled in the
wikinamespace and enabled everywhere else. Thestartpage is the only one with a pending approval.Before fixing
After fixing