Open
Conversation
A few quick fixes to make the explain plugin work with the newest Dokuwiki ("Igor").
splitbrain
requested changes
Oct 4, 2022
| foreach (array_keys($this->map) as $rxmatch) { | ||
| if ($match === $rxmatch || | ||
| ($this->map[$rxmatch]['i'] && utf8_strtolower($match) === $rxmatch)) { | ||
| ($this->map[$rxmatch]['i'] && strtolower($match) === $rxmatch)) { |
Member
There was a problem hiding this comment.
This breaks UTF-8 compatibility
Contributor
Author
There was a problem hiding this comment.
Good point. Would you settle for mb_strtolower then? Not perfect either but it will handle most of UTF-8.
Member
There was a problem hiding this comment.
no. please use the appropriate UTF-8 class provided with DokuWiki
Implemented __construct as suggested by jorbig, used Dokuwiki UTF-8 class, improved internal link handling and prevented undefined array warnings in render function. Tested with 2025-05-14a "Librarian" and PHP 8.3.23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few quick fixes to make the explain plugin work with the newest Dokuwiki ("Igor").