Open
Conversation
github-actions
bot
added
the
ibc-hooks
Author
|
Hi @jtieri, please let us know your thoughts about this, or please assign the responsible person to the reviewers. |
* fixed denom extraction * fixed the native denom * fixed acknowledgement interface * fixed interface compatiblity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
ibc-hooksmodule to align with the latestibc-gov10 API and dependencies. The key changes include updating the Go version and dependencies in thego.modfile, removing theCapabilityparameter from various hooks, and updating import paths to useibc-go/v10.Dependency Updates:
1.23.8and upgraded multiple dependencies inmodules/ibc-hooks/go.mod, includingcosmossdk.iopackages,github.com/cosmos/ibc-go(from v8 to v10), and other libraries.API Changes:
Capabilityparameter from multiple hooks such asOnChanOpenInit,OnChanOpenTry,SendPacket, andWriteAcknowledgementinmodules/ibc-hooks/hooks.goandmodules/ibc-hooks/ibc_module.go. This simplifies the function signatures. [1] [2] [3]Import Path Updates:
ibc-go/v8toibc-go/v10inmodules/ibc-hooks/hooks.goandmodules/ibc-hooks/ibc_module.go. [1] [2]These changes modernize the codebase and ensure compatibility with the latest
ibc-goversion while simplifying the middleware hooks by removing unused parameters.