fix(ibc-hooks) : align BeginBlock/EndBlock with new SDK interfaces#275
Merged
gjermundgaraba merged 2 commits intocosmos:mainfrom Sep 19, 2025
Merged
Conversation
github-actions
bot
added
the
ibc-hooks
gjermundgaraba
requested changes
Sep 17, 2025
gjermundgaraba
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, ibc-hooks defined BeginBlock/EndBlock in a way that no longer executed under the updated SDK interfaces. While these methods are effectively no-ops for the module, this change updates them to correctly implement the new interfaces for correctness and consistency. They could also be safely removed, but this keeps the implementation aligned with expected behaviour.