Skip to content

ci: add sonarcloud for go and js #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 12, 2024
Merged

ci: add sonarcloud for go and js #291

merged 6 commits into from
Mar 12, 2024

Conversation

@crodriguezvega
Copy link

@crodriguezvega crodriguezvega commented Mar 8, 2024

No description provided.

DimitrisJim
DimitrisJim reviewed Mar 8, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like this was triggered in this PR too #290 (comment) that doesn't touch go/typescript.

we might need to tweak the sonar.exclusions?

crodriguezvega and others added 2 commits March 8, 2024 19:59
@crodriguezvega @DimitrisJim
Update .github/workflows/typescript.yml
67d509c 
Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
@crodriguezvega
update project name
8fda5ea
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed for 'ics23'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@crodriguezvega
Copy link
Author

crodriguezvega commented Mar 8, 2024

seems like this was triggered in this PR too #290 (comment) that doesn't touch go/typescript.

we might need to tweak the sonar.exclusions?

Yeah, I am not sure if we can prevent that, because the project in SonarCloud was created for the whole repository... I didn't add a sonar-project.properties file for Rust, because it looks like code coverage support for Rust is not supported natively yet?

But I will update sonar.exclusions anyway.

DimitrisJim
DimitrisJim approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! fine with merging this now and tweaking any issues in follow ups if they pop up.

@crodriguezvega crodriguezvega merged commit b82084e into master Mar 12, 2024
@crodriguezvega crodriguezvega deleted the carlos/add-sonarcloud-go-js branch March 12, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@DimitrisJim DimitrisJim DimitrisJim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crodriguezvega @DimitrisJim