Skip to content

fix: use className prop in components where it was unused#735

Merged
pasqualevitiello merged 3 commits intocosscom:mainfrom
Valley-15:fix-unused-classname-props
Mar 29, 2026
Merged

fix: use className prop in components where it was unused#735
pasqualevitiello merged 3 commits intocosscom:mainfrom
Valley-15:fix-unused-classname-props

Conversation

@Valley-15
Copy link
Copy Markdown
Contributor

Summary

Ensured that className prop is properly used in CommandPanel, DrawerViewport, and SheetViewport components.

Fixes

Fixes #733

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 26, 2026

@Valley-15 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – coss-com-origin March 26, 2026 10:06 Inactive
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
coss-com-origin Skipped Skipped Mar 26, 2026 10:06am

Request Review

Copy link
Copy Markdown
Contributor

@pasqualevitiello pasqualevitiello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the contribution! We just need two quick fixes before moving forward:

Scope: Could you revert the changes in toggle-group.tsx? We try to keep PRs focused on one task to make auditing easier.

The Registry Flow: Since we use a registry system, changes need to be made in the source files at apps/ui/registry/default/ui. Once you've made your edits, run this command string from apps/ui to update the generated components:

bun format:all && bun registry:build && bun ui:sync

You can find the full breakdown of the registry architecture in the CONTRIBUTING.md.

@pasqualevitiello pasqualevitiello merged commit 2b7f45b into cosscom:main Mar 29, 2026
13 checks passed
@Valley-15
Copy link
Copy Markdown
Contributor Author

thanks @pasqualevitiello sir. I will make sure from now I will contribute more effectively and improve daily.

@Valley-15 Valley-15 deleted the fix-unused-classname-props branch March 31, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some className props are unused

2 participants