Skip to content

chore(deps): use grass_compiler directly#537

Merged
m4tx merged 1 commit intomasterfrom
grass_compiler
Mar 30, 2026
Merged

chore(deps): use grass_compiler directly#537
m4tx merged 1 commit intomasterfrom
grass_compiler

Conversation

@m4tx
Copy link
Copy Markdown
Member

@m4tx m4tx commented Mar 30, 2026

For our purposes, grass essentially re-exports grass_compiler. We can therefore skip one extra dependency and use grass_compiler instead.

Type of change

  • Bug fix
  • New feature
  • Documentation
  • Refactor / cleanup
  • Performance improvement
  • Other (describe above)

For our purposes, `grass` essentially re-exports `grass_compiler`. We can
therefore skip one extra dependency and use `grass_compiler` instead.
@m4tx m4tx requested review from ElijahAhianyo, Copilot and seqre March 30, 2026 19:04
@github-actions github-actions bot added A-deps Area: Dependencies C-lib Crate: cot (main library crate) labels Mar 30, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the cot crate’s SCSS build pipeline by removing the grass wrapper dependency and using grass_compiler directly, reducing one level of indirection in the workspace dependencies.

Changes:

  • Replace grass with grass_compiler in workspace dependencies and cot’s build-dependencies.
  • Update cot/build.rs to call grass_compiler::from_path and use grass_compiler::{Options, OutputStyle}.
  • Refresh Cargo.lock to remove the grass package entry and related dependency edge.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
cot/Cargo.toml Switch build-dependency to grass_compiler and update cargo-machete ignore comment accordingly.
cot/build.rs Update build script to call grass_compiler APIs directly for SCSS compilation.
Cargo.toml Replace workspace dependency grass with grass_compiler.
Cargo.lock Remove the resolved grass package and update dependency graph to grass_compiler.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

🐰 Bencher Report

Branchgrass_compiler
Testbedgithub-ubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
milliseconds (ms)
(Result Δ%)
Upper Boundary
milliseconds (ms)
(Limit %)
empty_router/empty_router📈 view plot
🚷 view threshold
6.71 ms
(+12.06%)Baseline: 5.99 ms
7.21 ms
(93.09%)
json_api/json_api📈 view plot
🚷 view threshold
1.19 ms
(+14.98%)Baseline: 1.04 ms
1.21 ms
(98.70%)
nested_routers/nested_routers📈 view plot
🚷 view threshold
1.10 ms
(+14.96%)Baseline: 0.96 ms
1.11 ms
(99.34%)
single_root_route/single_root_route📈 view plot
🚷 view threshold
1.06 ms
(+16.01%)Baseline: 0.92 ms
1.07 ms
(99.77%)
single_root_route_burst/single_root_route_burst📈 view plot
🚷 view threshold
17.04 ms
(-3.28%)Baseline: 17.62 ms
21.12 ms
(80.70%)
🐰 View full continuous benchmarking report in Bencher

@m4tx m4tx merged commit 3c11517 into master Mar 30, 2026
44 of 46 checks passed
@m4tx m4tx deleted the grass_compiler branch March 30, 2026 19:22
@cotbot cotbot bot mentioned this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-deps Area: Dependencies C-lib Crate: cot (main library crate)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants