Conversation
For our purposes, `grass` essentially re-exports `grass_compiler`. We can therefore skip one extra dependency and use `grass_compiler` instead.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the cot crate’s SCSS build pipeline by removing the grass wrapper dependency and using grass_compiler directly, reducing one level of indirection in the workspace dependencies.
Changes:
- Replace
grasswithgrass_compilerin workspace dependencies and cot’s build-dependencies. - Update
cot/build.rsto callgrass_compiler::from_pathand usegrass_compiler::{Options, OutputStyle}. - Refresh
Cargo.lockto remove thegrasspackage entry and related dependency edge.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cot/Cargo.toml |
Switch build-dependency to grass_compiler and update cargo-machete ignore comment accordingly. |
cot/build.rs |
Update build script to call grass_compiler APIs directly for SCSS compilation. |
Cargo.toml |
Replace workspace dependency grass with grass_compiler. |
Cargo.lock |
Remove the resolved grass package and update dependency graph to grass_compiler. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
seqre
approved these changes
Mar 30, 2026
|
| Branch | grass_compiler |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 6.71 ms(+12.06%)Baseline: 5.99 ms | 7.21 ms (93.09%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1.19 ms(+14.98%)Baseline: 1.04 ms | 1.21 ms (98.70%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 1.10 ms(+14.96%)Baseline: 0.96 ms | 1.11 ms (99.34%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 1.06 ms(+16.01%)Baseline: 0.92 ms | 1.07 ms (99.77%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 17.04 ms(-3.28%)Baseline: 17.62 ms | 21.12 ms (80.70%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For our purposes,
grassessentially re-exportsgrass_compiler. We can therefore skip one extra dependency and usegrass_compilerinstead.Type of change