Open
Conversation
github-actions
bot
added
A-deps
seqre
approved these changes
Mar 30, 2026
|
Bencher Report| Branch | remove-chumsky |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 5,026.20 µs(-16.46%)Baseline: 6,016.63 µs | 7,288.03 µs (68.97%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 893.78 µs(-14.44%)Baseline: 1,044.65 µs | 1,230.17 µs (72.65%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 858.05 µs(-10.77%)Baseline: 961.59 µs | 1,124.38 µs (76.31%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 819.25 µs(-11.30%)Baseline: 923.62 µs | 1,087.26 µs (75.35%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 15,205.00 µs(-13.89%)Baseline: 17,657.14 µs | 21,130.26 µs (71.96%) |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the workspace-level chumsky dependency and associated feature wiring, and drops the previously-added Windows linker/rustflags workaround in Cargo configs.
Changes:
- Remove
chumskyfrom workspace dependencies and fromcot’semailfeature/dependency list. - Delete Windows-specific
.cargo/config.tomlworkaround (both in repo root and the project template). - Update the project generator to no longer copy the template
.cargo/config.toml.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
cot/Cargo.toml |
Drops optional chumsky dep and removes it from the email feature. |
Cargo.toml |
Removes chumsky from [workspace.dependencies]. |
Cargo.lock |
Updates lockfile to reflect removal of chumsky from the resolved graph. |
.cargo/config.toml |
Removes Windows-specific linker/rustflags workaround. |
cot-cli/src/project_template/.cargo/config.toml |
Deletes the template’s Windows-specific cargo config workaround. |
cot-cli/src/new_project.rs |
Stops copying the template .cargo/config.toml into newly generated projects. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+16
to
19
| const PROJECT_FILES: [(&str, &str); 10] = [ | ||
| project_file!("Cargo.toml.template"), | ||
| project_file!("Cargo.lock.template"), | ||
| project_file!("bacon.toml"), |
There was a problem hiding this comment.
new_project copies Cargo.lock.template, but the current template lock file still contains chumsky (and is pinned to cot 0.5.0). This means freshly generated projects will still carry the dependency/version pins this PR is trying to remove. Please regenerate cot-cli/src/project_template/Cargo.lock.template from the updated template project (or stop shipping a lock template if it’s not meant to be kept in sync).
This removes the chumsky dependency, which was really just a `lettre` dependency, pinned to a specific version to avoid minimal version dependency issues. Also, this removes the workaround for rust-lang/rust#141626 which should be no longer needed now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the chumsky dependency, which was really just a
lettredependency, pinned to a specific version to avoid minimal version dependency issues.Also, this removes the workaround for rust-lang/rust#141626 which should be no longer needed now.
Type of change