-
Notifications
You must be signed in to change notification settings - Fork 2
Added Go starter-kit in README.md #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@hummusonrails This PR is ready for your review! |
|
Thanks, @Dhairya3124! I'm tagging in my colleagues @ldoguin and @shivaylamba to help with the PR review. |
|
Hey @hummusonrails Any update on this PR? |
|
Pinging @shivaylamba to take a look. 🔔 |
|
Hey @Dhairya3124 sure I will take a look at this shortly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the first iteration of the Golang starter kit.
Here are some high level comments:
- Currently the
main.gofile has code that references to the travel sample dataset.
in Line 41 you have the code:
cluster, err := gocb.Connect("couchbases://"+connectionString, options)
So either you can remove the "couchbases:// string from the code and allow the user to paste the entire connection string from the environment variable or mention this in the Github Readme.
-
Regarding the Github Workflow, please try to run that workflow and see if you are able to successfully run the action and update it to checkout Golang instead of the default Java.
-
In the README you have mentioned:
cd URL
This needs to be changed
- In the tests, create an actual test for one of the endpoints (could be the connection endpoint)
|
@shivay-couchbase Thanks for your review! I'll update accordingly and make changes. |
|
Hi @Dhairya3124 any updates since last time? |
|
Hey @shivay-couchbase I will try to complete it by this weekend. |
|
Hey @shivay-couchbase I have completed all the tasks now. Can you please give a quick review? Thanks |
|
Hey @shivay-couchbase Any changes required on this PR? |
|
Hi @Dhairya3124 my apologies for the delay, I will check back on this PR this week and get back to you |
|
Hey @shivay-couchbase Any other changes required from my side? |
Pull Request Template for New Couchbase Starter Kit Projects
Related Issue:
Please link to the issue your new project addresses:
Checklist:
Before submitting your pull request, ensure the following items have been completed:
.env.samplefile has been added with the necessary environment variables, following the template provided in the samples directory.README.mdfile is included with setup instructions.New Project Link:
Please provide the link to your new starter kit in the "Community Starter Kits" section of the contributing guide.
Add the details of your new starter kit to the table below in the following format:
Additional Notes: