Skip to content

#4: Initialize the import level at 0 instead of -1, for Python 3 compatibility#7

Open
nicoulaj wants to merge 1 commit intocournape:masterfrom
nicoulaj:patch-2
Open

#4: Initialize the import level at 0 instead of -1, for Python 3 compatibility#7
nicoulaj wants to merge 1 commit intocournape:masterfrom
nicoulaj:patch-2

Conversation

@nicoulaj
Copy link
Copy Markdown

(I did not test on Python 2 after this change)

@nicoulaj
Copy link
Copy Markdown
Author

@cournape any chance you could review this ?

@RafalSkolasinski
Copy link
Copy Markdown

Any chance this could be merged?

@pb-cdunn
Copy link
Copy Markdown

pb-cdunn commented Oct 6, 2020

This works great for me! I pip install --user import_profiler and then modify one line in-place. I'm glad it's so simple to fix.

@xingren23
Copy link
Copy Markdown

Any chance this could be merged?

@julien-blanchon
Copy link
Copy Markdown

Wtf why is this not merged ?

@prashantsengar-cl
Copy link
Copy Markdown

I forked to add support for Python 3 and it does work well. https://github.com/prashantsengar-cl/import-profiler.

I have made more changes other than the changes in this PR (also contributed #10 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants