Skip to content

Conversation

@eldhosejohn
Copy link
Contributor

@eldhosejohn eldhosejohn commented Aug 31, 2016

We are currently selecting either CONNECTION_STRING or CLUSTER_ID. This will cause error when try to run redshift shell ('dataduct sql_shell redshift') using jdbc connection string, as this requires CLUSTER_ID. Modified the code to pick the CONNECTION_STRING if both fields are available. This will make the sql shell to work.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 63.908% when pulling ef60d9d on eldhosejohn:fix_redshift_shell into 69b539e on coursera:develop.

@eldhosejohn
Copy link
Contributor Author

eldhosejohn commented Sep 29, 2016

This commit is connected with the following PR - #255. Here CLUSTER_ID is not considered (skipped) when CONNECTION_STRING is in use (i.e when connecting to Redshift hosted outside VPC). However CLUSTER_Id is required for the redshift shell (psql command) to work.

I am currently using dataduct in production. @sb2nov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants