Skip to content

Conversation

@jmg-duarte
Copy link
Contributor

Description

Migrates the shared crate off of ethcontract, dependency becomes based on ethrpc (which will be changed next)

Had to add an extra function to make this last one work before removing that API and others related to the old web3 library.

Changes

  • Migrate the last APIs on shared to alloy
  • Added erased to ethrpc to ease the transition — will be removed later

How to test

Existing tests

@jmg-duarte jmg-duarte requested a review from a team as a code owner January 12, 2026 15:17
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates the shared crate off of ethcontract, replacing it with alloy types and functions. The changes are clean and consistent, including the removal of the ethcontract dependency, updating use statements, and refactoring code to use alloy's idioms like U256::ONE and U256::MAX.

A temporary erased function has been added to ethrpc to facilitate this transition, and it is well-documented as a short-term hack. The rest of the changes correctly adapt to the new alloy-based types, removing now-unnecessary conversions. The code is more idiomatic and consistent after these changes. Overall, this is a solid refactoring effort with no apparent issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants