Migrate alerter crate from warp to axum #4045
Draft
+22
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace warp with axum for the alerter service's metrics endpoint. Add axum metrics handler to observe crate, gated behind the existing axum-tracing feature to maintain backward compatibility. Changes: - Add handle_metrics_axum() to observe crate (feature-gated) - Update alerter to use axum::Server::bind() API - Enable axum-tracing feature in alerter's observe dependency - Fix observe Cargo.toml to use dep:axum syntax for feature - Replace warp dependency with axum in alerter 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate the alerter crate from warp to axum (part of Q1 roadmap)
Changes
handle_metrics_axum()function to observe crate (feature-gated)dep:axumsyntaxHow to test
Playground and/or staging