Merged
Conversation
get_content() was the only user-facing challenge method without tests. Add two tests: dies without ACME instance, returns key authorization. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add tests for
http_01::get_content()— the only user-facing challenge method that lacked coverage.Why
All other challenge methods (
dns_01::get_record_value(),dns_account_01::get_record_value(),http_01::get_path()) have direct tests.get_content()was the gap.Testing
Two new tests added to
t/Net-ACME2-Challenge-http_01-Handler.t:Full test suite passes (12 tests in handler file, all suite tests pass).
🤖 Generated with Claude Code