Skip to content

optimization: cache contents() in __open paths #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atoomic merged 1 commit into from
Mar 28, 2026
Merged

optimization: cache contents() in __open paths #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lib/Test/MockFile.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2800,8 +2800,11 @@ sub _io_file_mock_open {
return;
}

# Cache contents() — it's non-trivial for directories (scans %files_being_mocked).
my $contents = $mock_file->contents();

# If contents is undef and reading, file doesn't exist
if ( !defined $mock_file->contents() && grep { $mode eq $_ } qw/< +</ ) {
if ( !defined $contents && grep { $mode eq $_ } qw/< +</ ) {
$! = ENOENT;
return;
}
Expand All @@ -2813,7 +2816,7 @@ sub _io_file_mock_open {

# Permission check (GH #3)
if ( defined $_mock_uid ) {
if ( defined $mock_file->contents() ) {
if ( defined $contents ) {
# Existing file: check file permissions
my $need = 0;
$need |= 4 if $rw =~ /r/;
Expand Down Expand Up @@ -3136,8 +3139,11 @@ sub __open (*;$@) {
return undef;
}

# Cache contents() — it's non-trivial for directories (scans %files_being_mocked).
my $contents = $mock_file->contents();

# If contents is undef, we act like the file isn't there.
if ( !defined $mock_file->contents() && grep { $mode eq $_ } qw/< +</ ) {
if ( !defined $contents && grep { $mode eq $_ } qw/< +</ ) {
$! = ENOENT;
_maybe_throw_autodie( 'open', @_ );
return undef;
Expand All @@ -3150,7 +3156,7 @@ sub __open (*;$@) {

# Permission check (GH #3) — IO::File path must match __open
if ( defined $_mock_uid ) {
if ( defined $mock_file->contents() ) {
if ( defined $contents ) {
my $need = 0;
$need |= 4 if $rw =~ /r/;
$need |= 2 if $rw =~ /w/;
Expand Down
Loading