fix: set $! to EINVAL on negative seek position#343
Draft
toddr-bot wants to merge 2 commits intocpan-authors:mainfrom
Draft
fix: set $! to EINVAL on negative seek position#343toddr-bot wants to merge 2 commits intocpan-authors:mainfrom
toddr-bot wants to merge 2 commits intocpan-authors:mainfrom
Conversation
Add assertions that $! is set to EINVAL when seek results in a negative file position. These tests currently fail, demonstrating the bug reported in issue cpan-authors#342. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Real Perl's seek() sets $! to EINVAL when the resulting file position would be negative. The mock SEEK method was correctly returning 0 (failure) but forgot to set the errno. Fixes cpan-authors#342. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sets
$!toEINVALwhenseek()results in a negative file position.Why
Real Perl's
seek()sets$!toEINVALwhen the resulting position would be negative. The mockSEEKmethod was returning 0 (failure) correctly but not setting errno, causing code that checks$!after a failed seek to get stale or wrong error codes. Fixes #342.How
One-line addition:
$! = EINVALbeforereturn 0in the negative-position guard ofFileHandle::SEEK.Testing
t/seek.t(one per whence mode: SEEK_SET, SEEK_CUR, SEEK_END)fh-ref-leak.tfailure)🤖 Generated with Claude Code