fix: add regression test for IST (India Standard Time) GH#9/RT#77886#101
Merged
atoomic merged 1 commit intocpan-authors:mainfrom Mar 21, 2026
Merged
Conversation
Verify that tz_offset("IST") returns +19800 (UTC+5:30) and that
time2str() applies the correct India Standard Time offset without
emitting "uninitialized value" warnings.
The fix (uncommenting the "ist" entry in Time/Zone.pm) was already
applied; this commit adds the missing regression test.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
istentry inTime::Zonewas historically commented out, causingtz_offset("IST")to returnundefandtime2str()to emit"Use of uninitialized value in addition"warnings while silently returning UTC time instead of India Standard Time (UTC+5:30). The fix (uncommenting the entry) was already applied to main; this PR adds the missing regression test.Fixes #9
Changes
t/gh9.t: verifiestz_offset("IST")returns+19800(+5:30) andtime2str()formats epoch 0 as05:30:00in IST with no warnings.Test plan
prove -lv t/gh9.t— all 3 assertions passprove -l t/— full suite (1220 tests) passes with no regressionsGenerated by Kōan /fix
Quality Report
Changes: 1 file changed, 25 insertions(+)
Code scan: clean
Tests: skipped
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline