fix: correct Czech strftime() calling wrong SUPER method#103
Draft
Koan-Bot wants to merge 1 commit intocpan-authors:mainfrom
Draft
fix: correct Czech strftime() calling wrong SUPER method#103Koan-Bot wants to merge 1 commit intocpan-authors:mainfrom
Koan-Bot wants to merge 1 commit intocpan-authors:mainfrom
Conversation
Czech.pm's strftime() method was calling $ref->SUPER::time2str(@A) instead of $ref->SUPER::strftime(@A). Since time2str() expects an epoch integer as its second argument but strftime() passes a localtime() array reference, the array ref was coerced to a number (its memory address), producing completely wrong dates (e.g., year 3269 instead of 1999). Add regression test covering strftime output, year sanity, and %o format for Czech. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
Date::Language::Czech::strftime()which was calling the wrong parent method.Why
Line 59 called
$ref->SUPER::time2str(@a)instead of$ref->SUPER::strftime(@a). Sincetime2str()expects an epoch integer butstrftime()passes alocaltime()array reference, the arrayref was coerced to its memory address, producing completely wrong dates (e.g., year 3269 instead of 1999).The
time2str()method on line 52 was correct — onlystrftime()had the copy-paste bug.Testing
t/czech-strftime.tcovers strftime output, year sanity, and%oformat🤖 Generated with Claude Code