Skip to content

Conversation

1uc
Copy link
Contributor

@1uc 1uc commented Sep 22, 2025

The pack Extents must be a pack of size_t integers.

The pack `Extents` must be a pack of `size_t` integers.
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mistake was in the incoming paper, but I agree it has to be a pack of size_t because otherwise extents<IndexType, Extents...> is ill-formed. But it needs to be changed in the [ndspan.syn] synopsis too.

@mhoemmen

Fix same typo in [mdspan.syn].
@1uc
Copy link
Contributor Author

1uc commented Sep 22, 2025

That makes sense. I've added a commit to address the issue. If you don't want to do a "squash and merge", let me know and I'll force push a single commit.

@1uc 1uc marked this pull request as ready for review September 22, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants