Conversation
mwoehlke-kitware
left a comment
There was a problem hiding this comment.
Thank you for your interest!
However, there are several major problems with your examples:
- Version 0.9 is quite old. Please target the current version 0.13.
- Please use JSON, not YAML. While CPS itself does not specify a transport, JSON is the de facto standard. YAML is much more difficult to parse.
- Most of your examples have serious deviations from the specification.
- Direct use of compile/link flags is strongly discouraged.
92a3a50 to
1473c42
Compare
|
@mwoehlke-kitware Thanks for reviewing it, please take a look again to see if that's better or anything can be added. |
mwoehlke-kitware
left a comment
There was a problem hiding this comment.
Better, but there are still some schema-conformance issues. (Note: comments on 'libbar' may apply to other examples.)
mwoehlke-kitware
left a comment
There was a problem hiding this comment.
Since you are hand-crafting these, please also validate them against the machine-readable schema.
|
@mwoehlke-kitware ok I just used https://www.jsonschemavalidator.net/ to validate these files and all looks good except |
|
Thanks.
That's a false report; the current version of the schema doesn't understand that optional attributes may be |
Add CPS examples as below: