configurations: Remove support for : as a separator#90
Open
dcbaker wants to merge 1 commit intocps-org:masterfrom
Open
configurations: Remove support for : as a separator#90dcbaker wants to merge 1 commit intocps-org:masterfrom
: as a separator#90dcbaker wants to merge 1 commit intocps-org:masterfrom
Conversation
`:` noted to be invalid on some platforms, notably on Windows. As such, one of the two biggest platform targets for CPS will not support `:`, and tools targeting both Windows and Linux or MacOS will likely not write the files, given that they would need two separate code paths to do so. Additionally, having a character that is known to not work on some platforms complicates cross compilation with binaries. For example, if a dependency is generated on Linux, then pulled onto a Windows system to do a Windows -> Linux cross compile, A CPS file that was valid on Linux containing a `:` will not work. Since there is already an alternative (using `-`), the most obvious solution is to simply drop `:` and only use `-`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:noted to be invalid on some platforms, notably on Windows. As such, one of the two biggest platform targets for CPS will not support:, and tools targeting both Windows and Linux or MacOS will likely not write the files, given that they would need two separate code paths to do so. Additionally, having a character that is known to not work on some platforms complicates cross compilation with binaries. For example, if a dependency is generated on Linux, then pulled onto a Windows system to do a Windows -> Linux cross compile, A CPS file that was valid on Linux containing a:will not work.Since there is already an alternative (using
-), the most obvious solution is to simply drop:and only use-.I've pulled this out of the discussion in #79 as an actionable item. I still have other concerns in that issue, but this seems straightforward and easy to resolve.