Skip to content

fix(test): IO safety violations while dropping the fd of open file #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WeepingClown13 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(test): IO safety violations while dropping the fd of open file #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions tests/test_close_fds.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,14 @@ fn run_basic_test(
),
builder: close_fds::CloseFdsBuilder,
) {
let f1 = std::fs::File::open("/").unwrap();
let f2 = std::fs::File::open("/").unwrap();
let f3 = std::fs::File::open("/").unwrap();

let fd1 = f1.as_raw_fd();
let fd2 = f2.as_raw_fd();
let fd3 = f3.as_raw_fd();
let path = std::ffi::CString::new("/").unwrap();

drop(f3);
let fd1 = unsafe { libc::open(path.as_ptr(), libc::O_RDONLY) };
let fd2 = unsafe { libc::open(path.as_ptr(), libc::O_RDONLY) };
let fd3 = unsafe { libc::open(path.as_ptr(), libc::O_RDONLY) };

unsafe { libc::close(fd3) };

assert!(is_fd_open(fd1));
assert!(is_fd_open(fd2));
Expand Down