Fix nil pointer dereference in TCPTransport.DoRaw #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
robert-cronin
force-pushed
the
fix/nil-pointer-dereference-in-do-raw
branch
from
d61ebcd to
5348b54
Compare
cpuguy83
approved these changes
Jun 26, 2025
Owner
|
Looks like one of the tests broke (incorrectly assuming structure of dockerhub image) but it is unrelated. LGTM, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
Initialize the dial field in TCPTransport to prevent panic when DoRaw is called.
The dial function was missing, causing a nil pointer dereference at transport.go:84.