Skip to content

adds ceiling and floor overflow/underflow tests #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raleigh-g-thompson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adds ceiling and floor overflow/underflow tests #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 80 additions & 0 deletions tests/cql/CqlArithmeticFunctionsTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,46 @@
<expression>Ceiling(1)</expression>
<output>1</output>
</test>
<test name="CeilingMaxInteger" version="1.0">
<expression>Ceiling(2147483647)</expression>
<output>2147483647</output>
</test>
<test name="CeilingMaxIntegerAsDecimal" version="1.0">
<expression>Ceiling(2147483647.0)</expression>
<output>2147483647</output>
</test>
<test name="CeilingMaxIntegerAsDecimalWhereDecimalIsNonZero" version="1.0">
<expression>Ceiling(2147483647.2)</expression>
<output>null</output>
</test>
<test name="CeilingIntegerGreaterThanMaxInteger" version="1.0">
<expression>Ceiling(2147483648)</expression>
Copy link
Member

@brynrhodes brynrhodes Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this expression? I think it might actually be invalid?

Copy link
Contributor Author

@raleigh-g-thompson raleigh-g-thompson Oct 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, SmileCDR returns this

 {
    "severity": "error",
    "details": {
        "text": "Bad format for Integer literal"
    }
}

Copy link
Contributor Author

@raleigh-g-thompson raleigh-g-thompson Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be marked as a semantic or runtime issue?

<output>null</output>
</test>
<test name="CeilingDecimalGreaterThanMaxInteger" version="1.0">
<expression>Ceiling(2147483648.2)</expression>
<output>null</output>
</test>
<test name="CeilingMinInteger" version="1.0">
<expression>Ceiling(-2147483648)</expression>
<output>-2147483648</output>
</test>
<test name="CeilingMinIntegerAsDecimal" version="1.0">
<expression>Ceiling(-2147483648.0)</expression>
<output>-2147483648</output>
</test>
<test name="CeilingMinIntegerAsDecimalWhereDecimalIsNonZero" version="1.0">
<expression>Ceiling(-2147483648.2)</expression>
<output>-2147483648</output>
</test>
<test name="CeilingIntegerLessThanMinInteger" version="1.0">
<expression>Ceiling(-2147483649)</expression>
Copy link
Member

@brynrhodes brynrhodes Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, seems like this would blow up in the parser?

<output>null</output>
</test>
<test name="CeilingDecimalLessThanMinInteger" version="1.0">
<expression>Ceiling(-2147483649.2)</expression>
<output>null</output>
</test>
</group>
<group name="Divide" version="1.0">
<capability code="arithmetic-operators"/>
Expand Down Expand Up @@ -202,6 +242,46 @@
<expression>Floor(2)</expression>
<output>2</output>
</test>
<test name="FloorMaxInteger" version="1.0">
<expression>Floor(2147483647)</expression>
<output>2147483647</output>
</test>
<test name="FloorMaxIntegerAsDecimal" version="1.0">
<expression>Floor(2147483647.0)</expression>
<output>2147483647</output>
</test>
<test name="FloorMaxIntegerAsDecimalWhereDecimalIsNonZero" version="1.0">
<expression>Floor(2147483647.2)</expression>
<output>2147483647</output>
</test>
<test name="FloorIntegerGreaterThanMaxInteger" version="1.0">
<expression>Floor(2147483648)</expression>
<output>null</output>
</test>
<test name="FloorDecimalGreaterThanMaxInteger" version="1.0">
<expression>Floor(2147483648.2)</expression>
<output>null</output>
</test>
<test name="FloorMinInteger" version="1.0">
<expression>Floor(-2147483648)</expression>
<output>-2147483648</output>
</test>
<test name="FloorMinIntegerAsDecimal" version="1.0">
<expression>Floor(-2147483648.0)</expression>
<output>-2147483648</output>
</test>
<test name="FloorMinIntegerAsDecimalWhereDecimalIsNonZero" version="1.0">
<expression>Floor(-2147483648.2)</expression>
<output>-2147483648</output>
</test>
<test name="FloorIntegerLessThanMinInteger" version="1.0">
<expression>Floor(-2147483649)</expression>
<output>null</output>
</test>
<test name="FloorDecimalLessThanMinInteger" version="1.0">
<expression>Floor(-2147483649.2)</expression>
<output>null</output>
</test>
</group>
<group name="Exp" version="1.0">
<capability code="arithmetic-operators"/>
Expand Down