[TS-38628] [Report-Generator] Migration to Kotlin #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DreierF
requested changes
Nov 14, 2024
agent/src/main/java/com/teamscale/jacoco/agent/DelayedLogger.java
Outdated
Show resolved
Hide resolved
report-generator/src/main/kotlin/com/teamscale/report/ReportUtils.kt
Outdated
Show resolved
Hide resolved
report-generator/src/main/kotlin/com/teamscale/report/ReportUtils.kt
Outdated
Show resolved
Hide resolved
report-generator/src/main/kotlin/com/teamscale/report/jacoco/CoverageFile.kt
Outdated
Show resolved
Hide resolved
report-generator/src/main/kotlin/com/teamscale/report/jacoco/FilteringAnalyzer.kt
Outdated
Show resolved
Hide resolved
report-generator/src/main/kotlin/com/teamscale/report/testwise/jacoco/cache/AnalyzerCache.kt
Outdated
Show resolved
Hide resolved
...-generator/src/main/kotlin/com/teamscale/report/testwise/jacoco/cache/ClassCoverageLookup.kt
Outdated
Show resolved
Hide resolved
report-generator/src/main/kotlin/com/teamscale/report/util/SortedIntList.kt
Outdated
Show resolved
Hide resolved
...-generator/src/main/kotlin/com/teamscale/report/testwise/jacoco/cache/ClassCoverageLookup.kt
Outdated
Show resolved
Hide resolved
report-generator/src/test/kotlin/com/teamscale/report/jacoco/JaCoCoXmlReportGeneratorTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the report-generator module from Java to Kotlin, leveraging the language's concise and expressive syntax. To achieve this, I initially used the automated translation tool of IntelliJ to convert the entire module, followed by a thorough manual review and refactoring of each file to ensure all tests pass.
The resulting code has been significantly improved, with a 25% reduction in overall code size. I replaced the custom SortedIntList class with the built-in SortedSet data structure, and rewrote iterative and hard-to-maintain code to utilize idiomatic Kotlin functional programming concepts. Every line of code has been carefully reviewed and refactored to ensure readability, maintainability, and performance.
Other modules will follow shortly.