Skip to content

Conversation

@Avanatiker
Copy link
Member

Migration of the Installer module. Follow up of #612

@Avanatiker Avanatiker requested a review from DreierF December 10, 2024 02:36
@Avanatiker
Copy link
Member Author

Teamscale not recognizing documented parameters in kdoc was already reported by me ages ago.

@cqse-teamscale-io
Copy link

  • installer/src/main/kotlin/com/teamscale/profiler/installer/HttpUrlTypeConverter.kt:10-11: [Test Gap] Added method convert has not been tested. (view in Teamscale)
  • installer/src/main/kotlin/com/teamscale/profiler/installer/InstallCommand.kt:28-42: [Test Gap] Added method call has not been tested. (view in Teamscale)
  • installer/src/main/kotlin/com/teamscale/profiler/installer/Installer.kt:173-208: [Test Gap] Added method install has not been tested. (view in Teamscale)
  • installer/src/main/kotlin/com/teamscale/profiler/installer/Installer.kt:212-218: [Test Gap] Added method get has not been tested. (view in Teamscale)
  • installer/src/main/kotlin/com/teamscale/profiler/installer/Installer.kt:143-166: [Test Gap] Added method get has not been tested. (view in Teamscale)
  • installer/src/main/kotlin/com/teamscale/profiler/installer/Installer.kt:226-252: [Test Gap] Added method uninstall has not been tested. (view in Teamscale)
  • installer/src/main/kotlin/com/teamscale/profiler/installer/RootCommand.kt:48-52: [Test Gap] Added method main has not been tested. (view in Teamscale)
  • installer/src/main/kotlin/com/teamscale/profiler/installer/RootCommand.kt:55-61: [Test Gap] Added method get has not been tested. (view in Teamscale)
  • installer/src/main/kotlin/com/teamscale/profiler/installer/RootCommand.kt:33-35: [Test Gap] Added method setInsecure has not been tested. (view in Teamscale)
  • installer/src/main/kotlin/com/teamscale/profiler/installer/UninstallCommand.kt:11-25: [Test Gap] Added method call has not been tested. (view in Teamscale)

See other 6 added untested methods.

@Avanatiker Avanatiker requested a review from DreierF January 9, 2025 19:01
@Avanatiker Avanatiker changed the title [TS-38628] [Installer] Migration to Kotlin [TS-38628] [Installer] Kotlin Migration Jan 15, 2025
@DreierF DreierF merged commit 9667ca1 into master Jan 16, 2025
6 of 7 checks passed
@DreierF DreierF deleted the ts/38628_kotlin_migration_installer branch January 16, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants