[8358] PathNavigatorTreeItem - childrenByParentPath LookupTable wrong validation

[jvega190]

craftercms/craftercms#8358

Summary by CodeRabbit

• Bug Fixes
  • Path navigation loading indicators now accurately reflect the data availability for each specific path instead of using a global check. This ensures users see correct loading states while browsing path structures.

[coderabbitai]

Walkthrough

The PR modifies the PathNavigatorTreeItem component to refine the condition for rendering loading/empty states. The public interface formatting is restructured across multiple lines without functional change, and the loading indicator now checks for children presence per-path rather than globally, with an added explanatory comment.

Changes

Cohort / File(s)	Summary
Loading State Condition Refinement ui/app/src/components/PathNavigatorTree/PathNavigatorTreeItem.tsx	Updated loading/empty state rendering condition from !childrenByParentPath.length to !childrenByParentPath[path]?.length to check children presence per specific path. Reformatted public interface declaration across multiple lines. Added clarifying comment about loading/error state distinction.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related issues

• PathNavigatorTreeItem - childrenByParentPath LookupTable wrong validation craftercms#8358: Directly addresses the same validation bug in PathNavigatorTreeItem by replacing the incorrect global length check with a per-path child presence check.

Suggested reviewers

• rart
• russdanner

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The description provides a ticket reference but lacks detail about the problem, solution, and testing. It minimally meets the template requirement with just the issue link.	Expand the description to explain what the validation bug was, why it occurred, how the fix addresses it, and any testing performed beyond the ticket reference.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically identifies the bug fix: validation issue with childrenByParentPath LookupTable in PathNavigatorTreeItem, with ticket reference.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}