[8358][4.x] PathNavigatorTreeItem - childrenByParentPath LookupTable wrong validation

[jvega190]

craftercms/craftercms#8358

[coderabbitai]

Summary by CodeRabbit

• Bug Fixes
  • Improved loading state indicator in the path navigator tree to display more accurately for individual paths.

Walkthrough

This change fixes a bug in the tree children loading state detection by replacing a global array length check with a per-path nullish-checked access, ensuring the loading indicator only displays when appropriate for the specific path being evaluated.

Changes

Cohort / File(s)	Summary
Tree Children Loading State ui/app/src/components/PathNavigatorTree/PathNavigatorTreeItem.tsx	Modified conditional from !childrenByParentPath.length to !childrenByParentPath[path]?.length to perform per-path check instead of checking total array length, fixing loading state logic for tree children.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related issues

• PathNavigatorTreeItem - childrenByParentPath LookupTable wrong validation craftercms#8358: Directly addresses the reported bug by implementing the per-path nullish-checked access fix for the children loading state detection.

Possibly related PRs

• [4.x][8441] Add items translation #4746: Both PRs modify PathNavigatorTree component logic; this PR refines the children-loading check while the related PR enhances i18n integration for PathNavigator/PathNavigatorTree components.

Suggested reviewers

• rart
• russdanner

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description only contains a GitHub issue link without additional context, failing to meet the template requirement for a ticket reference or full description of PR contents.	Expand the description to include a summary of what the fix addresses, why the validation was incorrect, and what the corrected behavior achieves.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the specific file and the nature of the fix (correcting validation logic for childrenByParentPath lookup table), directly matching the code changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}