Skip to content

[7504] Add disabled icon to IconGuideDashlet#4805

Open
jvega190 wants to merge 1 commit intocraftercms:developfrom
jvega190:enhancement/7504
Open

[7504] Add disabled icon to IconGuideDashlet#4805
jvega190 wants to merge 1 commit intocraftercms:developfrom
jvega190:enhancement/7504

Conversation

@jvega190
Copy link
Member

@jvega190 jvega190 commented Feb 17, 2026

craftercms/craftercms#7504

Summary by CodeRabbit

  • New Features
    • Added a new Disabled item visualization to the Icon Guide with a dedicated icon and localized label in the Workflow States section, providing clearer visual representation of available system status indicators.

@coderabbitai
Copy link

coderabbitai bot commented Feb 17, 2026

Walkthrough

Adds a visual representation of a disabled item in the Icon Guide Dashlet component, including a DisabledItemIcon and localized "Disabled" label within the existing Workflow States section (+12 lines).

Changes

Cohort / File(s) Summary
Icon Guide Enhancement
ui/app/src/components/IconGuideDashlet/IconGuideDashlet.tsx
Added Disabled item display with DisabledItemIcon and localized label to Workflow States section in the Icon Guide Dashlet.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • PR #4503: Introduces the DisabledItemIcon component that this PR consumes in the IconGuideDashlet, providing the foundational disabled-item icon rendering logic.
🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only provides a GitHub issue link without explaining what the PR does, why it's needed, or how it addresses the issue. Expand the description to explain the purpose of adding the disabled icon, the changes made, and how it relates to issue #7504.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a disabled icon to the IconGuideDashlet component.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@ui/app/src/components/IconGuideDashlet/IconGuideDashlet.tsx`:
- Around line 164-173: Replace the unsafe cast of types['component'] to
LightItem by constructing a proper LightItem object with the required properties
(e.g., include path, label and mimeType along with systemType) and pass that
object into DisabledItemIcon instead of using "as LightItem" on
types['component']; update any helper usage (e.g., getItemTypeText) to read from
the new LightItem object if needed. Also add an explicit id prop to the
FormattedMessage instance (for example id="words.disabled") to match the file's
translation pattern and tooling expectations.

@jvega190 jvega190 marked this pull request as ready for review February 17, 2026 17:14
@jvega190 jvega190 requested a review from rart as a code owner February 17, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments