Skip to content

[8377] Fix changelog entry#4807

Open
jvega190 wants to merge 1 commit intocraftercms:developfrom
jvega190:enhancement/8377
Open

[8377] Fix changelog entry#4807
jvega190 wants to merge 1 commit intocraftercms:developfrom
jvega190:enhancement/8377

Conversation

@jvega190
Copy link
Member

@jvega190 jvega190 commented Feb 18, 2026

craftercms/craftercms#8377

Summary by CodeRabbit

  • Refactor
    • Updated public action naming conventions for item completion operations to enhance consistency; refer to changelog for migration details

@jvega190 jvega190 requested a review from rart as a code owner February 18, 2026 16:17
@coderabbitai
Copy link

coderabbitai bot commented Feb 18, 2026

Walkthrough

The CHANGELOG is updated to reflect a naming swap in state/actions: fetchDetailedItemComplete is removed and replaced by fetchContentItemComplete as the completed-item fetch action, altering which action is considered public and deprecated.

Changes

Cohort / File(s) Summary
CHANGELOG Documentation
ui/app/src/CHANGELOG.md
Updated removed/replaced public action naming: fetchDetailedItemComplete is now removed instead of fetchContentItemComplete, which is retained as the replacement.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly references the issue number and describes the main change (fixing a changelog entry), which aligns with the actual modification to CHANGELOG.md.
Description check ✅ Passed The description provides the issue reference as required by the template but lacks additional context about the specific change or reasoning.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
ui/app/src/CHANGELOG.md (1)

129-133: Correct fix, but note the redundancy with the rename entry above.

The swap on line 133 is correct — the prior entry had the two action names inverted relative to the rename documented on line 129. However, line 129 (Renamed fetchDetailedItemComplete → fetchContentItemComplete) and line 133 (Removed fetchDetailedItemComplete. Replaced by fetchContentItemComplete) now convey the same breaking change from two angles. For consumers reading the changelog, this is harmless but slightly noisy.

Consider whether line 133 can simply be dropped, since line 129 already fully communicates that fetchDetailedItemComplete is gone and fetchContentItemComplete is its replacement. Alternatively, keeping both is fine if the intent is to make the removal explicit alongside the rename note.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@ui/app/src/CHANGELOG.md` around lines 129 - 133, The changelog now duplicates
the same breaking change: the rename of fetchDetailedItemComplete →
fetchContentItemComplete is already recorded in the rename bullet (mentioning
FETCH_DETAILED_ITEM_COMPLETE → FETCH_CONTENT_ITEM_COMPLETE), so remove the
redundant removal bullet that reads "Removed `fetchDetailedItemComplete` action.
Replaced by `fetchContentItemComplete`" (the entry referencing
fetchDetailedItemComplete/fetchContentItemComplete) to avoid noise;
alternatively, if you prefer to be explicit, keep one and delete the other so
only a single clear statement about the rename/removal of
fetchDetailedItemComplete remains.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@ui/app/src/CHANGELOG.md`:
- Around line 129-133: The changelog now duplicates the same breaking change:
the rename of fetchDetailedItemComplete → fetchContentItemComplete is already
recorded in the rename bullet (mentioning FETCH_DETAILED_ITEM_COMPLETE →
FETCH_CONTENT_ITEM_COMPLETE), so remove the redundant removal bullet that reads
"Removed `fetchDetailedItemComplete` action. Replaced by
`fetchContentItemComplete`" (the entry referencing
fetchDetailedItemComplete/fetchContentItemComplete) to avoid noise;
alternatively, if you prefer to be explicit, keep one and delete the other so
only a single clear statement about the rename/removal of
fetchDetailedItemComplete remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments