Skip to content

Conversation

Nemini-S
Copy link

Hi @jdtuck

This adds the package Rmfrac to the 'Time series of functional data' section of the task view.
I am the maintainer of this package.

Use "Rmfrac package provides tools for simulation and analysis of fractional and multifractional processes" if more shorter description is needed.

Feel free to edit or move to a more appropriate location.

Thanks.

@fabian-s
Copy link
Collaborator

thanks, seems like a good addition to the Task View.

However, running goodpractice::gp gives some warnings and your package currently does not contain ANY unit tests, can you adress these first please to improve the quality of the package:

extracted gp output:

write unit tests. The coverage of the package is currently 0%.write short and simple functions. These functions have high
    cyclomatic complexity (>50): exc_Area (101), cross_mean (82),
    sojourn (77), cross_T (73), cross_rate (70), long_streak (60),
    mean_streak (60). You can make them easier to reason about by
    encapsulating distinct steps of your function into subfunctions.use '<-' for assignment instead of '='. '<-' is the
    standard, and R users and developers are used it and it is easier
    to read your code for them if you use '<-'.

    inst/GHBMP_app/app.R:739:13
    inst/GHBMP_app/app.R:746:13
    inst/GHBMP_app/app.R:753:13
    inst/GHBMP_app/app.R:760:13
    inst/GHBMP_app/app.R:1207:13
    ... and 27 more linesavoid sapply(), it is not type safe. It might return a
    vector, or a list, depending on the input data. Consider using
    vapply() instead.

    inst/GHBMP_app/app.R:385:21
    inst/GHBMP_app/app.R:438:21
    inst/GHBMP_app/app.R:580:21
    inst/GHBMP_app/app.R:633:21
    inst/GHBMP_app/app.R:972:13
    ... and 47 more linesavoid 1:length(...), 1:nrow(...), 1:ncol(...), 1:NROW(...)
    and 1:NCOL(...) expressions. They are error prone and result 1:0 if
    the expression on the right hand side is zero. Use seq_len() or
    seq_along() instead.

    inst/GHBMP_app/app.R:393:19
    inst/GHBMP_app/app.R:446:19
    inst/GHBMP_app/app.R:588:19
    inst/GHBMP_app/app.R:641:19
    inst/GHBMP_app/app.R:1057:19
    ... and 21 more linesfix this R CMD check ERROR: Package required but not
    available:shinycssloadersSee sectionThe DESCRIPTION filein
    theWriting R Extensionsmanual.avoid 'T' and 'F', as they are just variables which are set
    to the logicals 'TRUE' and 'FALSE' by default, but are not reserved
    words and hence can be overwritten by the user.  Hence, one should
    always use 'TRUE' and 'FALSE' for the logicals.

    man/Hurst.Rd:NA:NA
    man/Hurst.Rd:NA:NA
    man/LFD.Rd:NA:NA
    man/LFD.Rd:NA:NA
    man/plot.mp.Rd:NA:NA
    ... and 1 more lines

@Nemini-S
Copy link
Author

Nemini-S commented Oct 1, 2025

Thanks for the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants