Conversation
5 tasks
goat-ssh
reviewed
Apr 23, 2026
| id="services", | ||
| ) | ||
|
|
||
| if exposure == "traefik": |
Contributor
There was a problem hiding this comment.
Wondering if we need to me more explicit in naming here (IngressRouteTCP), in future we might switch to Gateway API's TLSRoute...
Contributor
Author
There was a problem hiding this comment.
hmm, good point. do you think renaming traefik to ingressRouteTcp is fine, or should we split it into sth like exposure: loadbalancer | clusterip and add a separate field ingressController: traefik | gateway | none?
tomach
force-pushed
the
ta/traefik-exposure
branch
from
b495868 to
8e81e6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
CHANGES.rst