-
Notifications
You must be signed in to change notification settings - Fork 1
Polars: Index page #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polars: Index page #298
Conversation
|
Warning Rate limit exceeded@amotl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 17 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
WalkthroughPolars content was removed from docs/connect/df/index.md and replaced with a seealso link. A new Polars integration page was added at docs/integrate/polars/index.md. Navigation was updated in docs/integrate/index.md to include Polars in two toctrees. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (5)
docs/integrate/polars/index.md (4)
14-17: Tighten wording and avoid “language bindings for SQL”.Suggest neutral tone and precise phrasing.
-[Polars] is a blazingly fast DataFrames library with language bindings for -Rust, Python, Node.js, R, and SQL. Polars is powered by a multithreaded, -vectorized query engine, it is open source, and written in Rust. +[Polars] is a high‑performance DataFrames library with interfaces for +Rust, Python, Node.js, and R, plus a SQL context. It is powered by a +multithreaded, vectorized query engine and written in Rust.
32-34: US/UK spelling consistency: “utilises” → “utilizes”.Align with the repository’s prevailing style (appears to be US English).
-**Parallel:** Polars' multi-threaded query engine utilises the power of your +**Parallel:** Polars' multi-threaded query engine utilizes the power of your
50-55: Clarify how formats/backends are supported; verify DB list.Add qualifiers to avoid implying native drivers for every DB; “Azure File” likely “Azure Files” or “Azure Blob/ADLS”. Also, please verify Oracle/SQL Server support status.
-- Text: CSV & JSON -- Binary: Parquet, Delta Lake, AVRO & Excel -- IPC: Feather, Arrow -- Databases: MySQL, Postgres, SQL Server, Sqlite, Redshift & Oracle -- Cloud Storage: S3, Azure Blob & Azure File +- Text: CSV, JSON +- Binary: Parquet, Delta Lake, Avro, Excel +- IPC: Feather, Arrow IPC +- Databases: MySQL, PostgreSQL, SQLite, Redshift, SQL Server, (others via ConnectorX) +- Cloud storage: Amazon S3, Azure Blob/ADLS (via fsspec‑compatible backends)Optionally link to the official “I/O” docs here for each category after verification.
4-7: Avoid hotlinking the logo; vendor asset and consider dark/light variants.Hotlinking from GitHub raw can be brittle and slow; prefer a local asset and, if possible, theme‑aware variants.
-:style: "float: right; margin-left: 0.5em" -[{w=180px}][Polars] +:style: "float: right; margin-left: 0.5em" +[{w=180px}][Polars]If you want, I can add the asset to
_static/logos/and wire up light/dark variants.docs/connect/df/index.md (1)
90-92: Copy tweak for seealso.More concise phrasing.
-Please navigate to the dedicated page about {ref}`polars`. +See also: {ref}`polars`.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
docs/connect/df/index.md(1 hunks)docs/integrate/index.md(1 hunks)docs/integrate/polars/index.md(1 hunks)
🔇 Additional comments (2)
docs/integrate/index.md (1)
58-59: Navigation entry for Polars looks good.Position after plotly/index is consistent with alphabetical ordering. Ensure it appears only once across all toctrees.
docs/integrate/polars/index.md (1)
18-23: Qualify “without external dependencies” and I/O/backend claims.File: docs/integrate/polars/index.md Lines: 18-23
-**Fast:** Written from scratch in Rust and with performance in mind, - designed close to the machine, and without external dependencies. +**Fast:** Written in Rust with performance in mind, designed close to the + machine, and with minimal external dependencies. @@ -**I/O:** First class support for all common data storage layers: local, - cloud storage & databases. +**I/O:** First‑class support for common storage layers: local files, + cloud object stores (via fsspec‑compatible backends), and databases + (via connectors such as ConnectorX).Verified: ConnectorX supports PostgreSQL, MySQL/MariaDB, SQLite, Redshift, ClickHouse, SQL Server (including Azure SQL), Oracle, BigQuery, etc.; Polars supports S3, Azure Blob/ADLS and GCS via fsspec backends — optional packages required (connectorx, s3fs, adlfs, gcsfs).
docs/integrate/polars/index.md
Outdated
| - Text: CSV, JSON | ||
| - Binary: Parquet, Delta Lake, Avro, Excel | ||
| - IPC: Feather, Arrow IPC | ||
| - Databases: MySQL, PostgreSQL, SQLite, Redshift, SQL Server, (others via ConnectorX) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default of polars.read_database_uri is connectorx
| - Databases: MySQL, PostgreSQL, SQLite, Redshift, SQL Server, (others via ConnectorX) | |
| - Databases: MySQL, PostgreSQL, SQLite, Redshift, SQL Server... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with 3f5467c, thanks.
About
Just a bit of refactoring.
Preview
https://cratedb-guide--298.org.readthedocs.build/integrate/polars/