Skip to content

Conversation

@amotl
Copy link
Member

@amotl amotl commented Sep 14, 2025

@coderabbitai
Copy link

coderabbitai bot commented Sep 14, 2025

Warning

Rate limit exceeded

@amotl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 17 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 42e0502 and 3f5467c.

📒 Files selected for processing (3)
  • docs/connect/df/index.md (1 hunks)
  • docs/integrate/index.md (1 hunks)
  • docs/integrate/polars/index.md (1 hunks)

Walkthrough

Polars content was removed from docs/connect/df/index.md and replaced with a seealso link. A new Polars integration page was added at docs/integrate/polars/index.md. Navigation was updated in docs/integrate/index.md to include Polars in two toctrees.

Changes

Cohort / File(s) Summary
Polars content removal from Connect DF
docs/connect/df/index.md
Deleted the detailed Polars section and its references; replaced with a minimal seealso directive linking to the Polars page.
Integrations navigation update
docs/integrate/index.md
Inserted polars/index into two toctree sections (short and full) to expose the Polars integration in navigation.
New Polars integration page
docs/integrate/polars/index.md
Added a new page introducing Polars with logo, About, Data formats, and Learn sections, plus external links.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • hammerhead
  • bmunkholm
  • karynzv
  • surister

A hop and a skip through docs we go,
Polars now has its own burrow to show.
Links tidy the trails, no clutter in sight,
Carrots of clarity, crisp and bright.
Thump-thump—new paths mapped just so! 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Polars: Index page" is short, focused, and accurately describes the primary change in this changeset — adding/refactoring a Polars index documentation page and updating references/navigation — so it communicates the main intent to a reviewer scanning history.
Description Check ✅ Passed The description is minimal ("Just a bit of refactoring") but directly related to the changes (moving/removing Polars content and adding a Polars index) and includes a preview link, so under the lenient criteria it is acceptable and not off-topic.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@amotl amotl added the reorganize Moving content around, inside and between other systems. label Sep 15, 2025
@amotl amotl marked this pull request as ready for review September 15, 2025 22:28
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (5)
docs/integrate/polars/index.md (4)

14-17: Tighten wording and avoid “language bindings for SQL”.

Suggest neutral tone and precise phrasing.

-[Polars] is a blazingly fast DataFrames library with language bindings for
-Rust, Python, Node.js, R, and SQL. Polars is powered by a multithreaded,
-vectorized query engine, it is open source, and written in Rust.
+[Polars] is a high‑performance DataFrames library with interfaces for
+Rust, Python, Node.js, and R, plus a SQL context. It is powered by a
+multithreaded, vectorized query engine and written in Rust.

32-34: US/UK spelling consistency: “utilises” → “utilizes”.

Align with the repository’s prevailing style (appears to be US English).

-**Parallel:** Polars' multi-threaded query engine utilises the power of your
+**Parallel:** Polars' multi-threaded query engine utilizes the power of your

50-55: Clarify how formats/backends are supported; verify DB list.

Add qualifiers to avoid implying native drivers for every DB; “Azure File” likely “Azure Files” or “Azure Blob/ADLS”. Also, please verify Oracle/SQL Server support status.

-- Text: CSV & JSON
-- Binary: Parquet, Delta Lake, AVRO & Excel
-- IPC: Feather, Arrow
-- Databases: MySQL, Postgres, SQL Server, Sqlite, Redshift & Oracle
-- Cloud Storage: S3, Azure Blob & Azure File
+- Text: CSV, JSON
+- Binary: Parquet, Delta Lake, Avro, Excel
+- IPC: Feather, Arrow IPC
+- Databases: MySQL, PostgreSQL, SQLite, Redshift, SQL Server, (others via ConnectorX)
+- Cloud storage: Amazon S3, Azure Blob/ADLS (via fsspec‑compatible backends)

Optionally link to the official “I/O” docs here for each category after verification.


4-7: Avoid hotlinking the logo; vendor asset and consider dark/light variants.

Hotlinking from GitHub raw can be brittle and slow; prefer a local asset and, if possible, theme‑aware variants.

-:style: "float: right; margin-left: 0.5em"
-[![Polars logo](https://github.com/pola-rs/polars-static/raw/master/logos/polars-logo-dark.svg){w=180px}][Polars]
+:style: "float: right; margin-left: 0.5em"
+[![Polars logo](/_static/logos/polars-logo.svg){w=180px}][Polars]

If you want, I can add the asset to _static/logos/ and wire up light/dark variants.

docs/connect/df/index.md (1)

90-92: Copy tweak for seealso.

More concise phrasing.

-Please navigate to the dedicated page about {ref}`polars`.
+See also: {ref}`polars`.
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8946a4b and 42e0502.

📒 Files selected for processing (3)
  • docs/connect/df/index.md (1 hunks)
  • docs/integrate/index.md (1 hunks)
  • docs/integrate/polars/index.md (1 hunks)
🔇 Additional comments (2)
docs/integrate/index.md (1)

58-59: Navigation entry for Polars looks good.

Position after plotly/index is consistent with alphabetical ordering. Ensure it appears only once across all toctrees.

docs/integrate/polars/index.md (1)

18-23: Qualify “without external dependencies” and I/O/backend claims.

File: docs/integrate/polars/index.md Lines: 18-23

-**Fast:** Written from scratch in Rust and with performance in mind,
-  designed close to the machine, and without external dependencies.
+**Fast:** Written in Rust with performance in mind, designed close to the
+  machine, and with minimal external dependencies.
@@
-**I/O:** First class support for all common data storage layers: local,
-  cloud storage & databases.
+**I/O:** First‑class support for common storage layers: local files,
+  cloud object stores (via fsspec‑compatible backends), and databases
+  (via connectors such as ConnectorX).

Verified: ConnectorX supports PostgreSQL, MySQL/MariaDB, SQLite, Redshift, ClickHouse, SQL Server (including Azure SQL), Oracle, BigQuery, etc.; Polars supports S3, Azure Blob/ADLS and GCS via fsspec backends — optional packages required (connectorx, s3fs, adlfs, gcsfs).

- Text: CSV, JSON
- Binary: Parquet, Delta Lake, Avro, Excel
- IPC: Feather, Arrow IPC
- Databases: MySQL, PostgreSQL, SQLite, Redshift, SQL Server, (others via ConnectorX)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default of polars.read_database_uri is connectorx

Suggested change
- Databases: MySQL, PostgreSQL, SQLite, Redshift, SQL Server, (others via ConnectorX)
- Databases: MySQL, PostgreSQL, SQLite, Redshift, SQL Server...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with 3f5467c, thanks.

@amotl amotl merged commit 928b497 into main Sep 16, 2025
3 checks passed
@amotl amotl deleted the polars branch September 16, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reorganize Moving content around, inside and between other systems.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants