-
Notifications
You must be signed in to change notification settings - Fork 1
Chore: No line continuations in usage guides #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughMinor documentation edits across integration guides: wording and examples updated in the Dapr guide (explicit "Submit"/escaped SQL and explicit close operation), the InfluxDB index expanded into Server API and Line protocol workflows while removing the Synopsis from the InfluxDB usage page, and the Superset guide's CrateDB startup example simplified. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer (docs)
participant Client as App -> Dapr
participant Dapr as Dapr Bindings
participant Crate as CrateDB
rect rgb(220,240,255)
Note over Client,Dapr: Submit query/exec (explicit "Submit")
Client->>Dapr: POST /v1.0/bindings/cratedb { "operation":"Submit", "data": { ... } }
Dapr->>Crate: Execute SQL (exec/SELECT)
Crate-->>Dapr: Result / ACK
Dapr-->>Client: Response
end
rect rgb(240,255,220)
Note over Client,Dapr: Explicit close operation (new)
Client->>Dapr: POST /v1.0/bindings/cratedb { "operation":"close" }
Dapr->>Crate: Close connection pool
Crate-->>Dapr: Closed
Dapr-->>Client: Confirmation
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings, 1 inconclusive)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4a31bb1 to
3470ab8
Compare
About
A few more little fixes and improvements.
References