sendPostRequest should not force direct payment#36
Open
danybmx wants to merge 1 commit intocreagia:mainfrom
Open
sendPostRequest should not force direct payment#36danybmx wants to merge 1 commit intocreagia:mainfrom
danybmx wants to merge 1 commit intocreagia:mainfrom
Conversation
Member
|
Hi Daniel! You are right, I've only considered the recurrent payment case after an authorisation with redirect method. I don't have experience integrating with the REST method on Redsys but I think more changes will be need. For example, requests are always sent to Do you think you can extend this PR to handle any REST request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the sendPostRequest on RedsysRequest is forcing the directPayment property to true, that means that all payment request sent by that method are marked as "insecure payments", so no authentication is required.
This PR just remove that line so the user of the library could set the directPayment they want or don't do it to keep the default (false).