Skip to content

Onchange event is not being triggered with all options unchecked anym… #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Onchange event is not being triggered with all options unchecked anym… #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd9acf3
Onchange event is not being triggered with all options unchecked anym…
RSlijkhuis Jul 29, 2022
816015c
Merge branch 'master' into bugfix/triggering-an-onchange-with-all-opt…
RSlijkhuis Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 66 additions & 63 deletions src/AllCheckerCheckbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,83 +1,86 @@
import React, {
ForwardRefExoticComponent,
ReactElement,
useContext,
useEffect,
useState,
forwardRef,
RefAttributes
forwardRef,
ForwardRefExoticComponent,
ReactElement,
RefAttributes,
useContext,
useEffect,
useState,
} from 'react';

import CheckboxGroupContext from './CheckboxGroupContext';
import uuid from "./uuid";
import uuid from './uuid';

type AllCheckerCheckboxProps = Omit<React.DetailedHTMLProps<React.InputHTMLAttributes<HTMLInputElement>, HTMLInputElement> & RefAttributes<HTMLInputElement>, 'checked'>

const AllCheckerCheckbox: ForwardRefExoticComponent<AllCheckerCheckboxProps> = forwardRef((props, ref): ReactElement => {
const {
disabled,
onChange,
} = props;
const { disabled, onChange } = props;

const [id] = useState(uuid());
const checkboxGroup = useContext(CheckboxGroupContext);
const [id] = useState(uuid());
const checkboxGroup = useContext(CheckboxGroupContext);

const [initialized, setInitialized] = useState(false);
const [shouldTriggerCheckboxContextChange, setShouldTriggerCheckboxContextChange] = useState<boolean>(true);
const [isChecked, setIsChecked] = useState<boolean|undefined>(checkboxGroup.defaultChecked);
const [isDisabled, setIsDisabled] = useState(disabled !== undefined ? disabled : checkboxGroup.defaultDisabled);
const [initialized, setInitialized] = useState(false);
const [shouldTriggerCheckboxContextChange, setShouldTriggerCheckboxContextChange] = useState<boolean>(false);
const [isChecked, setIsChecked] = useState<boolean | undefined>(checkboxGroup.defaultChecked);
const [isDisabled, setIsDisabled] = useState(disabled !== undefined ? disabled : checkboxGroup.defaultDisabled);

useEffect((): () => void => {
checkboxGroup.assertIdDoesNotExist(id);
return (): void => {
checkboxGroup.allCheckerCheckboxes.delete(id);
};
}, []);
useEffect((): () => void => {
checkboxGroup.assertIdDoesNotExist(id);

useEffect((): void => {
checkboxGroup.allCheckerCheckboxes.set(id, {
isChecked,
isDisabled,
props,
setIsChecked,
setIsDisabled,
});
return (): void => {
checkboxGroup.allCheckerCheckboxes.delete(id);
};
}, []);

if (shouldTriggerCheckboxContextChange) {
checkboxGroup.onAllCheckerCheckboxChange(id, initialized);
setShouldTriggerCheckboxContextChange(false);
}
useEffect((): void => {
checkboxGroup.allCheckerCheckboxes.set(id, {
isChecked,
isDisabled,
props,
setIsChecked,
setIsDisabled,
});

if (!initialized) {
setInitialized(true);
}
}, [
id, isChecked, isDisabled, setIsChecked, setIsDisabled, initialized,
setShouldTriggerCheckboxContextChange, checkboxGroup, shouldTriggerCheckboxContextChange,
]);
if (shouldTriggerCheckboxContextChange) {
checkboxGroup.onAllCheckerCheckboxChange(id, initialized);
setShouldTriggerCheckboxContextChange(false);
}

const handleChange = (event: React.ChangeEvent<HTMLInputElement>): void => {
event.persist();
if (!initialized) {
setInitialized(true);
}
}, [
id,
isChecked,
isDisabled,
initialized,
checkboxGroup,
shouldTriggerCheckboxContextChange,
]);

if (!isDisabled) {
setShouldTriggerCheckboxContextChange(true);
setIsChecked(event.target.checked);
}
const handleChange = (event: React.ChangeEvent<HTMLInputElement>): void => {
event.persist();

if (onChange !== undefined) {
onChange(event);
}
};
if (!isDisabled) {
setShouldTriggerCheckboxContextChange(true);
setIsChecked(event.target.checked);
}

if (onChange !== undefined) {
onChange(event);
}
};

return (
<input
type="checkbox"
{...props}
ref={ref}
onChange={handleChange}
checked={isChecked !== undefined ? isChecked : false}
disabled={isDisabled !== undefined ? isDisabled : false}
/>
);
return (
<input
type="checkbox"
{...props}
ref={ref}
onChange={handleChange}
checked={isChecked !== undefined ? isChecked : false}
disabled={isDisabled !== undefined ? isDisabled : false}
/>
);
});

export default AllCheckerCheckbox;
132 changes: 65 additions & 67 deletions src/Checkbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,87 +1,85 @@
import React, {
forwardRef,
ForwardRefExoticComponent,
ReactElement,
RefAttributes,
useContext,
useEffect,
useState,
forwardRef,
ForwardRefExoticComponent,
ReactElement,
RefAttributes,
useContext,
useEffect,
useState,
} from 'react';

import CheckboxGroupContext from './CheckboxGroupContext';
import uuid from "./uuid";
import uuid from './uuid';

type CheckboxProps = React.DetailedHTMLProps<React.InputHTMLAttributes<HTMLInputElement>, HTMLInputElement> & RefAttributes<HTMLInputElement>;

const Checkbox: ForwardRefExoticComponent<CheckboxProps> = forwardRef((props, ref): ReactElement => {
const {
checked,
disabled,
onChange,
} = props;
const { checked, disabled, onChange } = props;

const [id] = useState(uuid());
const checkboxGroup = useContext(CheckboxGroupContext);
const [id] = useState(uuid());
const checkboxGroup = useContext(CheckboxGroupContext);

const [shouldTriggerCheckboxContextChange, setShouldTriggerCheckboxContextChange] = useState<boolean>(true);
const [isChecked, setIsChecked] = useState<boolean | undefined>(checked !== undefined ? checked : checkboxGroup.defaultChecked);
const [isDisabled, setIsDisabled] = useState<boolean | undefined>(disabled !== undefined ? disabled : checkboxGroup.defaultDisabled);
const [shouldTriggerCheckboxContextChange, setShouldTriggerCheckboxContextChange] = useState<boolean>(true);
const [isChecked, setIsChecked] = useState<boolean | undefined>(checked !== undefined ? checked : checkboxGroup.defaultChecked);
const [isDisabled, setIsDisabled] = useState<boolean | undefined>(disabled !== undefined ? disabled : checkboxGroup.defaultDisabled);

useEffect((): () => void => {
checkboxGroup.assertIdDoesNotExist(id);
return (): void => {
checkboxGroup.checkboxes.delete(id);
checkboxGroup.onCheckboxChange();
};
}, []);
useEffect((): () => void => {
checkboxGroup.assertIdDoesNotExist(id);

useEffect((): void => {
if (checked !== undefined) {
setShouldTriggerCheckboxContextChange(true);
setIsChecked(checked);
}
}, [checked, setIsChecked, setShouldTriggerCheckboxContextChange]);
return (): void => {
checkboxGroup.checkboxes.delete(id);
checkboxGroup.onCheckboxChange();
};
}, []);

useEffect((): void => {
checkboxGroup.checkboxes.set(id, {
isChecked,
isDisabled,
props,
setIsChecked,
setIsDisabled,
});
useEffect(() => {
setIsChecked(checked);
}, [checked]);

if (shouldTriggerCheckboxContextChange) {
checkboxGroup.onCheckboxChange();
setShouldTriggerCheckboxContextChange(false);
}
}, [
id, isChecked, isDisabled, setIsChecked, setIsDisabled,
setShouldTriggerCheckboxContextChange, checkboxGroup, shouldTriggerCheckboxContextChange,
]);
useEffect((): void => {
checkboxGroup.checkboxes.set(id, {
isChecked,
isDisabled,
props,
setIsChecked,
setIsDisabled,
});

const handleChange = (event: React.ChangeEvent<HTMLInputElement>) => {
event.persist();
if (shouldTriggerCheckboxContextChange) {
checkboxGroup.onCheckboxChange();
setShouldTriggerCheckboxContextChange(false);
}
}, [
id,
isChecked,
isDisabled,
checkboxGroup,
shouldTriggerCheckboxContextChange,
]);

if (!isDisabled) {
setShouldTriggerCheckboxContextChange(true);
setIsChecked(event.target.checked);
}
const handleChange = (event: React.ChangeEvent<HTMLInputElement>) => {
event.persist();

if (onChange !== undefined) {
onChange(event);
}
};
if (!isDisabled) {
setShouldTriggerCheckboxContextChange(true);
setIsChecked(event.target.checked);
}

if (onChange !== undefined) {
onChange(event);
}
};

return (
<input
type="checkbox"
{...props}
ref={ref}
onChange={handleChange}
checked={isChecked !== undefined ? isChecked : false}
disabled={isDisabled !== undefined ? isDisabled : false}
/>
);
return (
<input
type="checkbox"
{...props}
ref={ref}
onChange={handleChange}
checked={isChecked !== undefined ? isChecked : false}
disabled={isDisabled !== undefined ? isDisabled : false}
/>
);
});

export default Checkbox;
Loading