Skip to content

Trim input value and add exception handling for invalid URL #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shivam8112005 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Trim input value and add exception handling for invalid URL #298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/assets/js/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ document.addEventListener("DOMContentLoaded", function (e) {
console.log("captured cleanly!");

let form = {};
form.query = document.getElementById("query").value;
form.query = document.getElementById("query").value.trim();
form.commercial = document.getElementById("commercial").checked;
form.modify = document.getElementById("modify").checked;
selectedEngine = document.querySelector(
let selectedEngine = document.querySelector(
'input[name="search-engine"]:checked',
);
form.searchEngine = selectedEngine.value;
Expand All @@ -24,8 +24,15 @@ document.addEventListener("DOMContentLoaded", function (e) {

// navigate behavior
function navigateTo(link) {
if (link) {
window.open(link, "_blank");
try {
// Validate the URL using the URL constructor
new URL(link); // If the URL is invalid, it will throw an error
if (link) {
window.open(link, "_blank");// If valid, open the link in a new tab
}

} catch (error) {
console.error("Error occurred: ", error);
}
}

Expand Down