Fix/scroll to top issue54#137
Closed
Daodu111 wants to merge 5 commits intocreativecommons:mainfrom
Daodu111:fix/scroll-to-top-issue54
Closed
Fix/scroll to top issue54#137Daodu111 wants to merge 5 commits intocreativecommons:mainfrom Daodu111:fix/scroll-to-top-issue54
Daodu111 wants to merge 5 commits intocreativecommons:mainfrom
Daodu111:fix/scroll-to-top-issue54
Conversation
✅ Deploy Preview for vocabulary-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
HI @Daodu111 I think the issue here is that out of the 4 commits that are in this pull request, there are 2 that have nothing to do with the scroll to top functionalilty, which are the ones concerning fixing active state in the primary menu. Ideally, a PR should only contain commits that address the tagged issue. My guess is that you have worked on 2 issues on one branch. I would suggest you create a new branch and then fix the scroll to top issue only, then create a PR for it. Here is a link to my PR for this same issue for context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Description
I have worked on the comments you made here https://github.com/creativecommons/vocabulary/pull/65#issuecomment-2391867093
Technical details
Tests
Screenshots
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin