-
-
Notifications
You must be signed in to change notification settings - Fork 51
log: allow controlling command output redirection #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: allow controlling command output redirection #343
Conversation
|
@creativeprojects, let me know what you think about this and whether names need to be adjusted. |
755634a to
22c642a
Compare
|
Yes, this is a very good idea. I'm not too sure about the name of the flag either. We could also do:
🤔 |
|
name was also one thing were I wasn't sure yet. Had used Maybe Mostly the flag wont be needed as the |
0b14ca0 to
68c0331
Compare
68c0331 to
519d4b3
Compare
|
Changed the name to "command-output", kind of a combination of yours and mine proposals :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #343 +/- ##
==========================================
+ Coverage 71.03% 71.07% +0.05%
==========================================
Files 121 121
Lines 12378 12394 +16
==========================================
+ Hits 8792 8809 +17
+ Misses 3190 3189 -1
Partials 396 396
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4061506 to
5bf33d7
Compare
This PR is a super-light version of outstanding PR #207 to control when command output is sent to logs, console or both, with a default of "
auto" so that interactive usage isn't fully silent when log is specified (e.g. in global settings)... PR #207 is still required to have proper terminal output in this case but it is better than none.