Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve parameter validation in the
Submitterclass and adds corresponding tests to ensure the new functionality works correctly. The most important changes include modifying theverify_parameter_formatmethod to check for valid parameter values and adding new test cases tosubmitter_spec.rb.Improvements to parameter validation:
lib/submitter.rb: Modified theverify_parameter_formatmethod to include checks for both parameter format using regular expressions and valid parameter values from a predefined list of options.Enhancements to test coverage:
spec/submitter_spec.rb: Added new test cases to check the format using regular expressions, skip the format check when a format is not provided, and raise an error when a parameter value is not included in the predefined options.