Skip to content

Fix temperature normalization for gpt-5 search models #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −5
Open

Fix temperature normalization for gpt-5 search models #502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/ruby_llm/providers/openai/capabilities.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,12 +224,12 @@ def special_prefix_format(prefix)
end

def self.normalize_temperature(temperature, model_id)
if model_id.match?(/^(o\d|gpt-5)/)
RubyLLM.logger.debug "Model #{model_id} requires temperature=1.0, ignoring provided value"
1.0
elsif model_id.match?(/-search/)
if model_id.match?(/-search/)
RubyLLM.logger.debug "Model #{model_id} does not accept temperature parameter, removing"
nil
elsif model_id.match?(/^(o\d|gpt-5)/)
RubyLLM.logger.debug "Model #{model_id} requires temperature=1.0, ignoring provided value"
1.0
else
temperature
end
Expand Down
8 changes: 7 additions & 1 deletion spec/ruby_llm/providers/open_ai/capabilities_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,14 @@
end
end

it 'forces temperature to 1.0 for GPT-5 models' do
%w[gpt-5 gpt-5-mini gpt-5-nano].each do |model|
expect(described_class.normalize_temperature(0.7, model)).to eq(1.0)
end
end

it 'returns nil for search preview models' do
%w[gpt-4o-search-preview gpt-4o-mini-search-preview].each do |model|
%w[gpt-4o-search-preview gpt-4o-mini-search-preview gpt-5-search-api].each do |model|
expect(described_class.normalize_temperature(0.7, model)).to be_nil
end
end
Expand Down