feat: support mattermost notifications integration#261
Closed
BoxBoxJason wants to merge 1 commit intocrossplane-contrib:masterfrom
Closed
feat: support mattermost notifications integration#261BoxBoxJason wants to merge 1 commit intocrossplane-contrib:masterfrom
BoxBoxJason wants to merge 1 commit intocrossplane-contrib:masterfrom
Conversation
Contributor
Author
|
This won't work until the client-go (gitlab sdk) version is upgraded |
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
465405c to
9b21aa8
Compare
Collaborator
I think we should do that in a separate PR and do extensive testing. I will try to get something together for this. |
Contributor
Author
|
Closing as this is integrated in #268 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to add the support of the project level mattermost integration configuration, similar to what the terraform provider does.
I recommend a
squashmerge type to keep a clean history and a single commit for this featureRefs #250
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
kind create cluster --name gitlabhelm repo add crossplane-stable https://charts.crossplane.io/stablehelm install crossplane --namespace crossplane-system --create-namespace crossplane-stable/crossplanemake go.buildand then run it./_output/bin/linux_amd64/provider --debugk create secret generic gitlab-credentials -n crossplane-system --from-literal=token=EXAMPLE_VALUEexamples/projects/integration_mattermost.yaml