feat: protected environments#290
Open
Vadims-U wants to merge 2 commits intocrossplane-contrib:masterfrom
Open
Conversation
Signed-off-by: Vadims-U <vadims.ubikins@accenture.com>
Signed-off-by: Vadims-U <vadims.ubikins@accenture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds support for configuring GitLab Protected Environments via provider-gitlab.
It implements the Protected Environments API and introduces a new managed resource that allows users to define deploy access levels, approval rules, and required approval counts for project environments.
Fixes #269
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Automated
Added unit tests for client-side delta calculation and reconciliation logic.
Added controller unit tests covering Observe / Create / Update / Delete behavior and error paths.
Verified idempotent reconciliation behavior locally.
Ran make reviewable test
Manual
Tested locally against GitLab API using a standard Crossplane development setup.
Applied and updated ProtectedEnvironment resources and verified:
Test environment
Windows 11 with WSL2 (Ubuntu)
Podman‑based local Kubernetes cluster
Crossplane installed via Helm
Provider built and run locally in debug mode
Example manifest used during testing