Update crossplane runtime to v2#139
Closed
ricCap wants to merge 1 commit intocrossplane-contrib:mainfrom
Closed
Conversation
- Update crossplane-runtime from v1.20.0 to v2.0.0 - Implement missing interface methods for crossplane-runtime v2 compatibility: - Add GetUsers/SetUsers for UserCounter interface on ProviderConfig - Add GetItems for ProviderConfigUsageList interface - Add SetResourceReference/GetResourceReference for ProviderConfigUsage - Add compile-time interface validation with var _ assignments - Fix JQ expression syntax in e2e test examples: - Remove problematic outer parentheses from URL expressions - Fix Authorization header secret injection syntax - Add interface casting tests to prevent runtime panics - Update go.mod and go.sum for crossplane-runtime v2 dependencies - Use chainsaw for e2e tests Signed-off-by: Riccardo Capraro <capraroriccardo@gmail.com>
ricCap
commented
Oct 22, 2025
| Content-Type: | ||
| - application/json | ||
| Authorization: | ||
| - ("Bearer {{ auth:default:token }}") |
Contributor
Author
There was a problem hiding this comment.
This syntax was causing issues in e2e tests. It seemed that because of the parenthesis this was trying to be interpreted as a jq expression. Could you please let me know if you think this is a regression (or if this was broken before as well)?
Contributor
Author
There was a problem hiding this comment.
E2e tests (running with chainsaw) are failing the same against main as well ricCap#4
2 tasks
Contributor
Author
|
Closing in favour of #147 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This is a prerequisite for #128.
This PR is inspired by upjet provider examples crossplane-contrib/provider-upjet-azure#1019
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested