refactor: extract business logic to service package

[arielsepton]

Description

This PR refactors the HTTP provider to extract business logic from controllers into a dedicated service layer. This architectural change prepares the codebase to support namespace-scoped resources in Crossplane v2 by making the core HTTP request/response logic reusable across both cluster-scoped and namespace-scoped resource controllers.

Related to #141

Changes

Core Refactoring

• Extracted business logic to service layer: Moved HTTP request processing, observation, and action deployment logic from internal/controller to internal/service
• Introduced common interfaces: Created apis/interfaces/spec_accessors.go with interfaces (HTTPRequestSpec, SimpleHTTPRequestSpec, MappedHTTPRequestSpec) that abstract differences between Request and DisposableRequest types
• Spec accessor implementations: Added spec accessor methods for all resource versions (v1alpha1, v1alpha2) for both Request and DisposableRequest types

Service Package Structure

New internal/service package with resource-specific subdirectories:

• internal/service/request/ - Request resource business logic
  • deployaction.go - Action deployment (create/update/delete)
  • observe.go - Observation and up-to-date checking
  • Moved observation helpers: observe/, requestgen/, requestmapping/, statushandler/
• internal/service/disposablerequest/ - DisposableRequest resource business logic
  • deployaction.go - Action deployment
  • observe.go - Observation logic
  • validation.go - Validation logic

Controller Simplification

Controllers now delegate to service layer functions:

• internal/controller/request/request.go - Reduced from ~750 to ~40 lines of business logic
• internal/controller/disposablerequest/disposablerequest.go - Simplified significantly
• Removed observe.go, responseconverter/ from controllers (moved to service layer)

Testing

• Existing unit tests updated to use new service layer functions
• All tests pass with refactored code

[Copilot]

Pull Request Overview

This PR refactors the HTTP provider to extract business logic from controllers into a dedicated service layer. The refactoring introduces common interfaces to abstract differences between Request and DisposableRequest types, enabling code reuse and preparing the codebase for Crossplane v2 namespace-scoped resources support.

Key Changes:

• Introduced interface-based abstraction layer in apis/interfaces/spec_accessors.go with implementations across all API versions
• Extracted business logic from controllers to new internal/service package with resource-specific subdirectories
• Simplified controllers to delegate to service layer functions, reducing code duplication

Reviewed Changes

Copilot reviewed 43 out of 45 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
apis/interfaces/spec_accessors.go	Defines common interfaces for HTTP request specs, responses, and status management
apis/*/spec_accessors.go	Implements interface methods for all API versions (v1alpha1, v1alpha2)
apis/common/constants.go	Centralizes action and response check type constants
internal/service/request/*.go	Request resource business logic (observe, deploy, status handling)
internal/service/disposablerequest/*.go	DisposableRequest resource business logic (observe, deploy, validation)
internal/controller/*/*.go	Simplified controllers delegating to service layer
internal/utils/set_status.go	Updated to use new interfaces instead of local types
internal/data-patcher/patch.go	Updated to work with interface types
internal/clients/http/client.go	Added HTTPResponse interface implementation

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ricCap]

LGTM, thanks for the changes