[Android] Support third part media player on Crosswalk#3736
[Android] Support third part media player on Crosswalk#3736fujunwei wants to merge 1 commit intocrosswalk-project:masterfrom
Conversation
|
Testing patch series with fujunwei/crosswalk@024bae0 as its head.
|
| } | ||
|
|
||
| @XWalkAPI(reservable = true) | ||
| public void setExMediaPlayer(XWalkExMediaPlayerInternal mediaPlayer) { |
There was a problem hiding this comment.
Add the comment for this API?
|
Thanks @wuhengzhi Those proposals will be modified one by one. |
| @@ -9,11 +9,13 @@ | |||
| import android.media.MediaPlayer; | |||
|
One thing, I'm still confused by the name |
fujunwei
force-pushed
the
new_exo_media_player
branch
from
024bae0 to
9baa6c1
Compare
|
Testing patch series with fujunwei/crosswalk@9baa6c1 as its head.
|
|
Changed |
| } | ||
|
|
||
| /** | ||
| * Sets the data source (FileDescriptor) to use. |
There was a problem hiding this comment.
Lack of first parameter
There was a problem hiding this comment.
@param fd the FileDescriptor for the file you want to play.
fujunwei
force-pushed
the
new_exo_media_player
branch
from
9baa6c1 to
18f4196
Compare
|
Testing patch series with fujunwei/crosswalk@18f4196 as its head.
|
|
|
||
| /** | ||
| * Sets the volume on this player. | ||
| * @since 7.0 |
There was a problem hiding this comment.
Missing the explanation for parameters.
7 participants
A requirement from an important customer who want to forward web resources with proxy
on Crosswalk, but android system MediaPlayer can't set a proxy with a standard API.
The ExoMediaPlayer is playing videos and music is a popular activity on Android devices,
and it can be configured with proxy.
https://developer.android.com/guide/topics/media/exoplayer.html
BUG=XWALK-6770