Skip to content

Conversation

@serhii-londar
Copy link
Collaborator

@serhii-londar serhii-londar commented Jan 11, 2026

Note

Locks live-dependent unit tests behind an environment flag and stabilizes CI test execution.

  • Gate multiple XCTest classes with setUpWithError + XCTSkipUnless(ProcessInfo... ["CROWDIN_LIVE_TESTS"] == "1") to skip tests unless a live distribution is enabled
  • Disable Xcode parallel test execution by adding -parallel-testing-enabled NO in .github/workflows/build.yml
  • Improve test reliability by fulfilling expectations on error paths in CrowdinSupportedLanguagesThreadSafetyTests and ensuring proper SDK cleanup in tearDown

Written by Cursor Bugbot for commit 79ffb6f. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings January 11, 2026 20:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serhii-londar as I understand it, these tests will only execute locally when CROWDIN_LIVE_TESTS is enabled. I'm concerned about the reliability of such tests. We can't control whether everyone will run them locally, so they could become outdated or broken without our knowledge.

I would suggest improving the tests environment by mocking the distribution of creating some test distribution.

@serhii-londar
Copy link
Collaborator Author

@andrii-bodnar We have test distribution and test currently using it. I wanted to make tests more stable, by disabling live tests for now. I suggest closing this request and disabling parallel tests execution in #363. Let's check whether it will help at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants